Extract nested classes to separate files#66
Open
FroggieFrog wants to merge 1 commit intoua-parser:masterfrom
Open
Extract nested classes to separate files#66FroggieFrog wants to merge 1 commit intoua-parser:masterfrom
FroggieFrog wants to merge 1 commit intoua-parser:masterfrom
Conversation
Contributor
|
Finally had a look at this. Beyond the move to separate files, I think you also moved some classes into other namespaces (Implementations, Abstractions, Extensions)? I am personally not a fan of such a separation but more critical is that it'll break backwards compatibility if we move existing classes to new namespaces. I would prefer a fully flat namespace. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This idea for this PR is based on #60, but it just extracts all nested classes to their own files (
CTRL + .and "Move to xx.cs"). this is common best pratice in the .NET world.Also all files were formatted via
Edit->Advanced->Format Document.Hopefully it makes it easier to add the performance improvements from #60 and future ones.